From 4ce16a08fc8d3b6ae765eddcdc4d20e503c9b3a4 Mon Sep 17 00:00:00 2001 From: Marc Durdin Date: Wed, 1 Nov 2023 05:57:13 +0700 Subject: [PATCH] fix(developer): don't use osk-always-visible on touch devices Fixes #9845. It seems that the logic for `osk-always-visible` is not quite right on touch devices -- the OSK disappears on blur but remains touchable -- so presses in the OSK region emit key events. For Keyman Developer Server, the simple workaround is to only use `` when on desktop devices. We should review the logic for `osk-always-visible` in KeymanWeb, so that this issue does not arise on touch devices. This patch addresses the issue in Keyman Developer Server, and matches the behaviour we want on touch devices in any case, as we don't really want the OSK visible when blurred, unlike on desktop. --- developer/src/server/src/site/index.html | 2 +- developer/src/server/src/site/test.js | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/developer/src/server/src/site/index.html b/developer/src/server/src/site/index.html index 5a4fd139a5..8147a849a4 100644 --- a/developer/src/server/src/site/index.html +++ b/developer/src/server/src/site/index.html @@ -21,7 +21,7 @@ - +
diff --git a/developer/src/server/src/site/test.js b/developer/src/server/src/site/test.js index 6014c8ab26..b162048917 100644 --- a/developer/src/server/src/site/test.js +++ b/developer/src/server/src/site/test.js @@ -42,6 +42,10 @@ function enableControls(enable) { let keymanInitialized = false; enableControls(false); +if(!keyman.util.isTouchDevice()) { + document.body.className = 'osk-always-visible'; +} + keyman.init({ ui:'button', resources:'/resource/',