From 4bfb35c19fc33cdfecbae2604d5255c8dab9da78 Mon Sep 17 00:00:00 2001
From: Eberhard Beilharz <eb1@sil.org>
Date: Thu, 12 Jun 2025 18:28:15 +0200
Subject: [PATCH] maint(developer): use double quotes so that variable gets
 replaced

This fixes developer release builds. Previously we used single quotes
for specifying `--rsync-path`. This caused the parameter to contain
the variable name instead of the content.

Follow-up-of: #14059
Part-of: #13399
Test-bot: skip
---
 .../teamcity/developer/download-symbol-server-index.ps1     | 6 +++---
 resources/teamcity/developer/publish-new-symbols.ps1        | 2 +-
 .../teamcity/developer/publish-to-downloads-keyman-com.ps1  | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/resources/teamcity/developer/download-symbol-server-index.ps1 b/resources/teamcity/developer/download-symbol-server-index.ps1
index bc80706e36..ffa0d97ba1 100644
--- a/resources/teamcity/developer/download-symbol-server-index.ps1
+++ b/resources/teamcity/developer/download-symbol-server-index.ps1
@@ -25,7 +25,7 @@ $rsync_args = @(
   '-vrzltp',                                # verbose, recurse, zip, copy symlinks, preserve times, permissions
   '--chmod=Dug=rwx,Do=rx,Fug=rw,Fo=r',      # map Windows security to host security
   '--stats',                                # show statistics for log
-  '--rsync-path="$RSYNC_PATH"',             # path on remote server
+  "--rsync-path='$RSYNC_PATH'",             # path on remote server
   "--rsh=$RSYNC_HOME\ssh -i $USERPROFILE\.ssh\id_rsa -o UserKnownHostsFile=$USERPROFILE\.ssh\known_hosts",                  # use ssh
   "$RSYNC_USER@$RSYNC_HOST:$RSYNC_ROOT/windows/symbols/000admin/lastid.txt", # target server + path
   "."                                       # download the whole symbols 000Admin folder
@@ -38,7 +38,7 @@ $rsync_args = @(
   '-vrzltp',                                # verbose, recurse, zip, copy symlinks, preserve times, permissions
   '--chmod=Dug=rwx,Do=rx,Fug=rw,Fo=r',      # map Windows security to host security
   '--stats',                                # show statistics for log
-  '--rsync-path="$RSYNC_PATH"',             # path on remote server
+  "--rsync-path='$RSYNC_PATH'",             # path on remote server
   "--rsh=$RSYNC_HOME\ssh -i $USERPROFILE\.ssh\id_rsa -o UserKnownHostsFile=$USERPROFILE\.ssh\known_hosts",                  # use ssh
   "$RSYNC_USER@$RSYNC_HOST:$RSYNC_ROOT/windows/symbols/000admin/history.txt", # target server + path
   "."                                       # download the whole symbols 000Admin folder
@@ -51,7 +51,7 @@ $rsync_args = @(
   '-vrzltp',                                # verbose, recurse, zip, copy symlinks, preserve times, permissions
   '--chmod=Dug=rwx,Do=rx,Fug=rw,Fo=r',      # map Windows security to host security
   '--stats',                                # show statistics for log
-  '--rsync-path="$RSYNC_PATH"',             # path on remote server
+  "--rsync-path='$RSYNC_PATH'",             # path on remote server
   "--rsh=$RSYNC_HOME\ssh -i $USERPROFILE\.ssh\id_rsa -o UserKnownHostsFile=$USERPROFILE\.ssh\known_hosts",                  # use ssh
   "$RSYNC_USER@$RSYNC_HOST:$RSYNC_ROOT/windows/symbols/000admin/server.txt", # target server + path
   "."                                       # download the whole symbols 000Admin folder
diff --git a/resources/teamcity/developer/publish-new-symbols.ps1 b/resources/teamcity/developer/publish-new-symbols.ps1
index bf7d090b93..40c43df1c8 100644
--- a/resources/teamcity/developer/publish-new-symbols.ps1
+++ b/resources/teamcity/developer/publish-new-symbols.ps1
@@ -27,7 +27,7 @@ $rsync_args = @(
   '-vrzltp',                                # verbose, recurse, zip, copy symlinks, preserve times, permissions
   '--chmod=Dug=rwx,Do=rx,Fug=rw,Fo=r',      # map Windows security to host security
   '--stats',                                # show statistics for log
-  '--rsync-path="$RSYNC_PATH"',             # path on remote server
+  "--rsync-path='$RSYNC_PATH'",             # path on remote server
   "--rsh=$RSYNC_HOME\ssh -i $USERPROFILE\.ssh\id_rsa -o UserKnownHostsFile=$USERPROFILE\.ssh\known_hosts",                  # use ssh
   ".",                                      # upload the whole symbols folder
   "$RSYNC_USER@$RSYNC_HOST:$RSYNC_ROOT/windows/symbols/" # target server + path
diff --git a/resources/teamcity/developer/publish-to-downloads-keyman-com.ps1 b/resources/teamcity/developer/publish-to-downloads-keyman-com.ps1
index 1899e694cb..884e098afa 100644
--- a/resources/teamcity/developer/publish-to-downloads-keyman-com.ps1
+++ b/resources/teamcity/developer/publish-to-downloads-keyman-com.ps1
@@ -144,7 +144,7 @@ $rsync_args = @(
   '-vrzltp',                                # verbose, recurse, zip, copy symlinks, preserve times, permissions
   '--chmod=Dug=rwx,Do=rx,Fug=rw,Fo=r',      # map Windows security to host security
   '--stats',                                # show statistics for log
-  '--rsync-path="$RSYNC_PATH"',             # path on remote server
+  "--rsync-path='$RSYNC_PATH'",             # path on remote server
   "--rsh=$RSYNC_HOME\ssh -i $USERPROFILE\.ssh\id_rsa -o UserKnownHostsFile=$USERPROFILE\.ssh\known_hosts",                  # use ssh
   "$build_number",                          # upload the whole build folder
   "$RSYNC_USER@$RSYNC_HOST:$RSYNC_ROOT/developer/$tier/" # target server + path
@@ -204,7 +204,7 @@ $rsync_args = @(
   '-vrzltp',                                # verbose, recurse, zip, copy symlinks, preserve times, permissions
   '--chmod=Dug=rwx,Do=rx,Fug=rw,Fo=r',      # map Windows security to host security
   '--stats',                                # show statistics for log
-  '--rsync-path="$RSYNC_PATH"',             # path on remote server
+  "--rsync-path='$RSYNC_PATH'",             # path on remote server
   "--rsh=$RSYNC_HOME\ssh -i $USERPROFILE\.ssh\id_rsa -o UserKnownHostsFile=$USERPROFILE\.ssh\known_hosts",                  # use ssh
   "$build_number",                          # upload the whole build folder
   "$RSYNC_USER@$RSYNC_HOST:$RSYNC_ROOT/developer/$tier/" # target server + path