From 4bbafa69036853f6001401bc83fa621f8742e9fd Mon Sep 17 00:00:00 2001 From: "Steven R. Loomis" Date: Thu, 16 Nov 2023 12:11:41 -0600 Subject: [PATCH] =?UTF-8?q?feat(core):=20marker=20normalization=20=20?= =?UTF-8?q?=F0=9F=99=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - literally a bad assert. the error case is handled below, in fact the unit test tests for it. - for some reason, assert.h wasn't included in some cases locally. For: #9468 --- core/src/ldml/ldml_transforms.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/core/src/ldml/ldml_transforms.cpp b/core/src/ldml/ldml_transforms.cpp index 5773152ff9..5c4ff428cd 100644 --- a/core/src/ldml/ldml_transforms.cpp +++ b/core/src/ldml/ldml_transforms.cpp @@ -10,10 +10,7 @@ #include #include #include "kmx/kmx_xstring.h" - -#ifndef assert -#define assert(x) ((void)0) -#endif +#include namespace km { namespace core { @@ -1004,7 +1001,6 @@ std::u32string remove_markers(const std::u32string &str, marker_map *markers) { } // #2 LDML_MARKER_CODE - assert(*i == LDML_MARKER_CODE); if (*i != LDML_MARKER_CODE) { continue; // can't process this, get out }