erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-08-12 03:45:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

fix(ios): move sentry settings responsibility to build agent

Browse source 
The build agent already has the relevant `SENTRY_` environment variables
set in order to complete builds for all projects. Thus, we should
exclude these values from the xcode build. However, we need to ensure
that the `SENTRY_URL` and `SENTRY_ORG` variables are imported into the
xcode environment from the build agent environment.
This commit is contained in:
Marc Durdin 2021-10-07 12:30:25 +11:00
parent 5b134219fa
commit 4ac8ca9085
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
resources/build/build-utils.sh
View file

@ -198,6 +198,8 @@ function exportEnvironmentDefinitionScript() {
echo "# Required for successful dSYM upload for Sentry error reporting" >> "$ENVIRONMENT_SH"
echo "export SENTRY_AUTH_TOKEN=${SENTRY_AUTH_TOKEN:-}" >> "$ENVIRONMENT_SH"
echo "export SENTRY_URL=${SENTRY_URL:-}" >> "$ENVIRONMENT_SH"
echo "export SENTRY_ORG=${SENTRY_ORG:-}" >> "$ENVIRONMENT_SH"
# Ensure the autogenerated file may be successfully run/included by xcode-utils.sh.
chmod +x "$ENVIRONMENT_SH"

2
resources/build/xcode-utils.sh
View file

@ -129,8 +129,6 @@ function phaseSentryDsymUpload() {
# The remaining update logic seen here was auto-generated at https://sentry.keyman.com/keyman/keyman-ios/getting-started/cocoa-swift/
if which sentry-cli >/dev/null; then
export SENTRY_URL="https://sentry.keyman.com"
export SENTRY_ORG=keyman
export SENTRY_PROJECT="$SENTRY_PROJECT_TARGET"
export SENTRY_LOG_LEVEL=info
ERROR=$(sentry-cli upload-dif "$DWARF_DSYM_FOLDER_PATH" 2>&1 >/dev/null)