From 4540a501f63e57ecb3098e6fff4dff686fcb83bd Mon Sep 17 00:00:00 2001 From: Eberhard Beilharz Date: Mon, 30 Sep 2024 16:03:03 +0200 Subject: [PATCH] docs(common): mention `KEYMAN_USE_NVM` in minimum versions doc Also fix a typo in a comment in a script file. --- resources/build/minimum-versions.inc.sh | 2 +- resources/locate_emscripten.inc.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/build/minimum-versions.inc.sh b/resources/build/minimum-versions.inc.sh index f58e7575d9..6f0211895a 100644 --- a/resources/build/minimum-versions.inc.sh +++ b/resources/build/minimum-versions.inc.sh @@ -18,7 +18,7 @@ KEYMAN_MIN_TARGET_VERSION_UBUNTU=20.04 # Ubuntu 20.04 Focal KEYMAN_MIN_TARGET_VERSION_CHROME=95.0 # Final version that runs on Android 5.0 # Dependency versions -KEYMAN_MIN_VERSION_NODE_MAJOR=20 # node version source of truth is /package.json:/engines/node +KEYMAN_MIN_VERSION_NODE_MAJOR=20 # node version source of truth is /package.json:/engines/node; use KEYMAN_USE_NVM to automatically update KEYMAN_MIN_VERSION_NPM=10.5.1 # 10.5.0 has bug, discussed in #10350 KEYMAN_MIN_VERSION_EMSCRIPTEN=3.1.58 # Use KEYMAN_USE_EMSDK to automatically update to this version KEYMAN_MIN_VERSION_VISUAL_STUDIO=2019 diff --git a/resources/locate_emscripten.inc.sh b/resources/locate_emscripten.inc.sh index 3d470f7577..1d185f5552 100644 --- a/resources/locate_emscripten.inc.sh +++ b/resources/locate_emscripten.inc.sh @@ -41,7 +41,7 @@ locate_emscripten() { } # Ensure that we use correct version of emsdk on build agents. -# For developers, define KEYMAN_USE_SDK to do this on your +# For developers, define KEYMAN_USE_EMSDK to do this on your # build machine. verify_emscripten_version() { if [[ "$VERSION_ENVIRONMENT" != local || ! -z "${KEYMAN_USE_EMSDK+x}" ]]; then