diff --git a/web/src/engine/common/web-utils/src/rewindable-cache.ts b/web/src/engine/common/web-utils/src/rewindable-cache.ts index 32fd796dd3..d7023c3617 100644 --- a/web/src/engine/common/web-utils/src/rewindable-cache.ts +++ b/web/src/engine/common/web-utils/src/rewindable-cache.ts @@ -57,7 +57,7 @@ export class RewindableCache { get(key: Key): Value { const set = this.cacheOrderSet; if(!set.has(key)) { - return null; + return undefined; } set.delete(key); diff --git a/web/src/engine/common/web-utils/src/tests/rewindableCache.tests.js b/web/src/engine/common/web-utils/src/tests/rewindableCache.tests.js index de7ea97c71..4524149ea5 100644 --- a/web/src/engine/common/web-utils/src/tests/rewindableCache.tests.js +++ b/web/src/engine/common/web-utils/src/tests/rewindableCache.tests.js @@ -87,11 +87,10 @@ describe("RewindableCache", () => { const cache = new RewindableCache(2); cache.add(1, 'a'); cache.add(2, 'b'); - cache.add(3, 'c'); - cache.add(4, 'd'); - cache.add(5, 'e'); + cache.add(3, 'c'); // Entry 1 no longer valid + cache.add(4, 'd'); // 2 + cache.add(5, 'e'); // 3 - assert.doesNotThrow(() => cache.get(2)); assert.throws(() => cache.rewindTo(3)); }); @@ -99,11 +98,11 @@ describe("RewindableCache", () => { const cache = new RewindableCache(2); cache.add(1, 'a'); cache.add(2, 'b'); - cache.add(3, 'c'); - cache.add(4, 'd'); - cache.add(5, 'e'); + cache.add(3, 'c'); // Entry 1 no longer valid + cache.add(4, 'd'); // 2 + cache.add(5, 'e'); // 3 - assert.doesNotThrow(() => cache.peek(2)); - assert.doesNotThrow(() => cache.get(2)); + assert.isUndefined(cache.peek(2), 'outdated cache entry should be forgotten'); + assert.isUndefined(cache.get(2), 'outdated cache entry should be forgotten'); }); }); \ No newline at end of file