From 34f144259a8b4ef651a0a392eaa323fa1cd52b8a Mon Sep 17 00:00:00 2001 From: Marc Durdin Date: Thu, 22 Feb 2024 10:12:17 +0700 Subject: [PATCH] fix(developer): strip paths from keymanweb sourcemaps when uploading to sentry For keymanweb distribution only, strip all paths from sourcemaps when uploading to Sentry, by running the sourcemap upload from the specific folder. This maps to sentry-manager's stripping of paths in its reporting. --- developer/src/tools/sentry-upload-difs.sh | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/developer/src/tools/sentry-upload-difs.sh b/developer/src/tools/sentry-upload-difs.sh index 21c84f8420..52d1463775 100755 --- a/developer/src/tools/sentry-upload-difs.sh +++ b/developer/src/tools/sentry-upload-difs.sh @@ -71,13 +71,24 @@ echo "Uploading symbols for developer/" --no-zips \ src/ -for sourcemap_path in "${sourcemap_paths[@]}"; do - ./src/kmc/node_modules/.bin/sentry-cli sourcemaps upload \ +upload_sourcemap() { + local smpath="$1" + "$KEYMAN_ROOT/developer/src/kmc/node_modules/.bin/sentry-cli" sourcemaps upload \ --no-dedupe \ --org keyman \ --project keyman-developer \ --release "$VERSION_GIT_TAG" \ --dist "$VERSION_ENVIRONMENT" \ --ext js --ext mjs --ext ts --ext map \ - "$sourcemap_path" + "$smpath" +} + +# Separate sourcemap upload for KeymanWeb to avoid pathing +cd "$KEYMAN_ROOT/developer/bin/server/build/src/site/resource" +upload_sourcemap . +cd "$KEYMAN_ROOT/developer" + +# Upload all other sourcemaps +for sourcemap_path in "${sourcemap_paths[@]}"; do + upload_sourcemap "$sourcemap_path" done