erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-11-03 09:37:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

change(web): Apply EB suggestions from code review
Some checks failed
Keyman Build Summary / Summarize build status checks (push) Has been cancelled
Details

Browse source 
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
This commit is contained in:
Joshua Horton 2026-05-15 01:47:47 +07:00 • committed by GitHub
parent 53bc2288dc
commit 30f2f363b3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
web/src/test/auto/headless/engine/predictive-text/helpers/constituentPaths.tests.ts
View file

@ -89,7 +89,7 @@ describe('constituentPaths', () => {
return type == 'insert' && typeSeq[index+1] == 'delete';
});
});
assert.isNotOk(shouldOccur);
assert.isOk(shouldOccur);
});
});
});

5
web/src/test/auto/headless/engine/predictive-text/helpers/constituentPaths.ts
View file

@ -28,7 +28,8 @@ export function constituentPaths(node: SearchQuotientNode): SearchQuotientSpur[]
} else if(node instanceof SearchQuotientCluster) {
return node.parents.flatMap((p) => constituentPaths(p));
} else if(node instanceof SearchQuotientSpur) {
const parentPaths = constituentPaths(node.parents[0]); let pathsToExtend = parentPaths;
const parentPaths = constituentPaths(node.parents[0]);
let pathsToExtend = parentPaths;
if(node instanceof InsertionQuotientSpur) {
pathsToExtend = pathsToExtend.filter(s => {
@ -36,7 +37,7 @@ export function constituentPaths(node: SearchQuotientNode): SearchQuotientSpur[]
// Deletion nodes and modules should always be ordered after those for
// insertion in order to avoid duplicating search paths. (Insertions may
// stick to the right of a root, while deletions always process inputs; they
// stick to the right of a root, while deletions always process inputs; insertions
// may thus precede deletions.)
//
// Also, internally, insertion edges are not built after deletion (or empty) edges.