From 2cc013bd33cfbbb96896f884257f4ed92bb339c5 Mon Sep 17 00:00:00 2001 From: jahorton Date: Wed, 27 May 2020 12:45:10 +0700 Subject: [PATCH] change(ios): better UPLOAD_SENTRY default implementation --- resources/build/build-utils.sh | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/resources/build/build-utils.sh b/resources/build/build-utils.sh index de51f6dd0c..b52d8916d6 100755 --- a/resources/build/build-utils.sh +++ b/resources/build/build-utils.sh @@ -142,29 +142,16 @@ function printVersionUtilsDebug() { } function findShouldSentryRelease() { - # Default, in case $VERSION_ENVIRONMENT is improperly specified. + # Default, for 'test' or 'local' environment, or in case $VERSION_ENVIRONMENT is improperly specified. + # (May be overridden by -upload-sentry in supporting build scripts.) UPLOAD_SENTRY=false - # Dynamically configure whether or not to upload Sentry symbols. + # Default: override to `true` for release builds. case $VERSION_ENVIRONMENT in # Actual release tiers - alpha) + alpha | beta | stable) UPLOAD_SENTRY=true ;; - beta) - UPLOAD_SENTRY=true - ;; - stable) - UPLOAD_SENTRY=true - ;; - - # Development builds; do not release (by default). - local) - UPLOAD_SENTRY=false - ;; - test) - UPLOAD_SENTRY=false - ;; esac }