erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-09-24 00:27:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Apply suggestions from code review

Browse source 
Co-authored-by: Marc Durdin <marc@durdin.net>
This commit is contained in:
Darcy Wong 2023-11-16 15:10:18 +07:00 • committed by GitHub
parent b41f049036
commit 2b34c641f3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
android/KMAPro/kMAPro/src/main/assets/banner/banner.html
View file

@ -1,6 +1,5 @@
<!-- Custom banner theme -->
<div style="background: white; width: 100%; height: 100%; position: absolute; left: 0; top: 0; display: flex">
<!--<div style="height: 1px; left: 0; position: absolute; top: 0; width: 100%; background: black"></div>-->
<!-- svg path is relative to assets/ folder -->
<img src="banner/keyman_banner.svg" style="height:60%; background: white; display: block; margin: auto 2%;">

2
android/KMAPro/kMAPro/src/main/java/com/keyman/android/BannerController.java
View file

@ -11,7 +11,7 @@ public class BannerController {
// Paths relative to assets folder for banner themes
public static final String KM_BANNER_DIR = "banner";
public static final String KM_BANNER_THEME_KEYMAN = KM_BANNER_DIR + "/banner.html";
public static final String KM_BANNER_THEME_KEYMAN = "banner.html";
public static void setHTMLBanner(Context context, KMManager.KeyboardType keyboardType) {
if (keyboardType == KMManager.KeyboardType.KEYBOARD_TYPE_UNDEFINED) {

4
android/KMEA/app/src/main/assets/android-host.js
View file

@ -304,10 +304,6 @@ function hideKeyboard() {
window.location.hash = 'hideKeyboard' + fragmentToggle;
}
function doResetContext() {
keyman.resetContext();
}
function showKeyboard() {
// Refresh KMW OSK
keyman.refreshOskLayout();

1
oem/firstvoices/android/app/src/main/assets/banner/banner.html
View file

@ -1,6 +1,5 @@
<!-- Custom banner theme -->
<div style="background: #aa1225; width: 100%; height: 100%; position: absolute; left: 0; top: 0; display: flex">
<!--<div style="height: 1px; left: 0; position: absolute; top: 0; width: 100%; background: black"></div>-->
<!-- svg path is relative to assets/ folder -->
<img src="banner/red-logo.svg" style="height:60%; background: #aa1225; display: block; margin: auto 2%;">

2
oem/firstvoices/android/app/src/main/java/com/firstvoices/android/BannerController.java
View file

@ -11,7 +11,7 @@ public class BannerController {
// Paths relative to assets folder for banner themes
public static final String FV_BANNER_DIR = "banner";
public static final String FV_BANNER_THEME = FV_BANNER_DIR + "/banner.html";
public static final String FV_BANNER_THEME = "banner.html";
public static void setHTMLBanner(Context context, KMManager.KeyboardType keyboardType) {
if (keyboardType == KMManager.KeyboardType.KEYBOARD_TYPE_UNDEFINED) {