From 1ffae64dfb8116a4f3970219d2b67bd780d6c64e Mon Sep 17 00:00:00 2001 From: Joshua Horton Date: Tue, 14 Jan 2025 10:40:38 +0700 Subject: [PATCH] chore: apply suggestions from code review --- resources/builder.inc.sh | 2 +- resources/builder_completion.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/resources/builder.inc.sh b/resources/builder.inc.sh index 572f3a8389..c94e8df22d 100755 --- a/resources/builder.inc.sh +++ b/resources/builder.inc.sh @@ -1407,7 +1407,7 @@ _builder_parse_expanded_parameters() { # internal reporting function, ignores all other parameters _builder_report_dependencies ;; - --builder_completion_describe) + --builder-completion-describe) _builder_completion_describe exit 0 ;; diff --git a/resources/builder_completion.sh b/resources/builder_completion.sh index 03aad40d5a..abb8f3de7e 100755 --- a/resources/builder_completion.sh +++ b/resources/builder_completion.sh @@ -1,4 +1,4 @@ -#!/usr/bin/env bash +# As this script must be sourced by shells to be useful, no practical #shebang is possible. # Note: must 'source' this file again in the terminal after any edits! _comp_builder() { @@ -25,7 +25,7 @@ _comp_builder() { # Is it actually a builder-script? If not, abort. If so, it defines # a special option used to provide us with completion-target data. - local builder_params=`${CMD_PATH} --builder_completion_describe` || exit 0 + local builder_params=`${CMD_PATH} --builder-completion-describe` || exit 0 local BASE_NAME=$(basename "$CMD_PATH") local BUILDER_ARG_STR="${COMP_LINE##*${BASE_NAME} }"