erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-08-12 03:45:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

Recent change from escape/unescape to encodeURI/decodeURI should have been to encodeURIComponent/decodeURIComponent

Browse source
This commit is contained in:
Marc Durdin 2018-03-01 09:01:56 +07:00
parent 384a5d9b23
commit 1cd0d2bb31
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
web/source/kmwcallback.ts
View file

@ -1108,7 +1108,7 @@ class KeyboardInterface {
this.resetContextCache();
var cName='KeymanWeb_'+kbdName+'_Option_'+storeName,cValue=this.keymanweb.util.loadCookie(cName);
if(typeof cValue[storeName] != 'undefined') {
return decodeURI(cValue[storeName]);
return decodeURIComponent(cValue[storeName]);
} else {
return dfltValue;
}
@ -1128,7 +1128,7 @@ class KeyboardInterface {
return false;
}
var cName='KeymanWeb_'+kbd['KI']+'_Option_'+storeName, cValue=encodeURI(optValue);
var cName='KeymanWeb_'+kbd['KI']+'_Option_'+storeName, cValue=encodeURIComponent(optValue);
this.keymanweb.util.saveCookie(cName,cValue);
return true;

4
web/source/kmwutils.ts
View file

@ -747,7 +747,7 @@ class Util {
var cx = this.loadCookie();
for(var t in cx) {
if(t == cn) {
var d = decodeURI(cx[t]).split(';');
var d = decodeURIComponent(cx[t]).split(';');
for(var i=0; i<d.length; i++) {
var xc = d[i].split('=');
if(xc.length > 1) {
@ -785,7 +785,7 @@ class Util {
}
var d = new Date(new Date().valueOf() + 1000 * 60 * 60 * 24 * 30).toUTCString();
document.cookie = cn+'='+encodeURI(s)+'; path=/; expires='+d;//Fri, 31 Dec 2099 23:59:59 GMT;';
document.cookie = cn+'='+encodeURIComponent(s)+'; path=/; expires='+d;//Fri, 31 Dec 2099 23:59:59 GMT;';
}
/**