From 1884706cd0e9bb67cd53e0cd2b3d4e9b8b5d14f2 Mon Sep 17 00:00:00 2001
From: Eddie Antonio Santos <Eddie.Santos@nrc-cnrc.gc.ca>
Date: Wed, 26 Aug 2020 14:42:22 -0600
Subject: [PATCH] changes(developer/compilers): apply suggestions from #3506
 review

Co-authored-by: Marc Durdin <marc@durdin.net>
---
 .../js/libexec/create-override-script-regexp.ts | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/developer/js/libexec/create-override-script-regexp.ts b/developer/js/libexec/create-override-script-regexp.ts
index d5793862d8..3307144431 100755
--- a/developer/js/libexec/create-override-script-regexp.ts
+++ b/developer/js/libexec/create-override-script-regexp.ts
@@ -16,7 +16,7 @@ const SPACELESS_SCRIPT_BLOCKS = new Set([
 ]);
 
 let blockIter = blocks();
-let block = nextBlock()
+let block = nextBlock();
 
 let elligibleCharacters = [];
 
@@ -29,16 +29,16 @@ for (let {codePoint, generalCategory} of unicodeData()) {
   console.assert(block.contains(codePoint));
 
   if (SPACELESS_SCRIPT_BLOCKS.has(block.name) && isLetterOrMark(generalCategory)) {
-    elligibleCharacters.push(codePoint)
+    eligibleCharacters.push(codePoint);
   }
 }
 
-let ranges = groupCodePointsIntoRanges(elligibleCharacters)
+const ranges = groupCodePointsIntoRanges(eligibleCharacters);
 
-let characterClasses = ranges.map(([lower, upper]) => {
+const characterClasses = ranges.map(([lower, upper]) => {
   if (lower === upper) {
     return unicodeEscape(lower);
-  } else if (lower == upper - 1) {
+  } else if (lower === upper - 1) {
     return unicodeEscape(lower) + unicodeEscape(upper);
   } else {
     return `${unicodeEscape(lower)}-${unicodeEscape(upper)}`;
@@ -107,7 +107,7 @@ function groupCodePointsIntoRanges(characters: number[]): [number, number][] {
   let ranges = [];
 
   let previousCharacter = characters[0];
-  let candidates = characters.slice(1);
+  const candidates = characters.slice(1);
   let currentRange: [number, number] = [previousCharacter, previousCharacter];
   for (let codePoint of candidates) {
     if (codePoint === previousCharacter + 1) {
@@ -128,7 +128,6 @@ function unicodeEscape(codePoint: number) {
     throw new Error("non-BMP code points not supported");
   }
 
-  let hex = codePoint.toString(16).toUpperCase();
-  let leadingZeros = "0".repeat(4 - hex.length);
-  return `\\u${leadingZeros}${hex}`;
+  let hex = codePoint.toString(16).toUpperCase().padStart(4,'0');
+  return `\\u${hex}`;
 }