erabo/spiegel-keyman
1
0
Fork 0
mirror of https://github.com/keymanapp/keyman.git synced 2026-08-16 05:39:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Merge pull request #1301 from keymanapp/ios-1166-reachability-crash-fix

Browse source 
[iOS] System keyboard + Reachability crash fix
This commit is contained in:
Joshua Horton 2018-11-15 10:32:50 +07:00 • committed by GitHub
commit 06342c2d7c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ios/engine/KMEI/KeymanEngine.xcodeproj/project.pbxproj
View file

@ -824,7 +824,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "if which swiftlint >/dev/null; then\n swiftlint --config ../../.swiftlint.yml\nelse\n echo \"warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint\"\nfi";
shellScript = "if which swiftlint >/dev/null; then\n swiftlint --config ../../.swiftlint.yml\nelse\n echo \"warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint\"\nfi\n";
};
C0A5FF391F6684DE00BE740C /* ShellScript */ = {
isa = PBXShellScriptBuildPhase;

7
ios/engine/KMEI/KeymanEngine/Classes/Manager.swift
View file

@ -181,9 +181,12 @@ public class Manager: NSObject, HTTPDownloadDelegate, UIGestureRecognizerDelegat
keymanWeb.view.addGestureRecognizer(hold)
reachability = Reachability(hostName: keymanHostName)
NotificationCenter.default.addObserver(self, selector: #selector(self.reachabilityChanged),
if(!Util.isSystemKeyboard) {
NotificationCenter.default.addObserver(self, selector: #selector(self.reachabilityChanged),
name: .reachabilityChanged, object: reachability)
reachability.startNotifier()
reachability.startNotifier()
}
/* HTTPDownloader only uses this for its delegate methods. So long as we don't
* set the queue running, this should be perfectly fine.

1
ios/history.md
View file

@ -5,6 +5,7 @@
* Bookmark add button is enabled only when title/url fields have text (#1073)
* Removed deprecated code to to support keyman:// scheme for ad-hoc distribution (#1160)
* Updated the default keyboard to SIL EuroLatin (#1101)
* Fixed bug behind some crashes of system keyboard (#1166)
## 2018-08-02 10.0.208 stable
* Fixed OSK layout problems (and possible crash) on iOS 11 on certain hardware (#1089, #1159)

8
ios/keymanios.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings Normal file
View file

@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>BuildSystemType</key>
<string>Original</string>
</dict>
</plist>