From ea51d918d791a0dbe7a29fa1acfbec2d61dc4479 Mon Sep 17 00:00:00 2001 From: adabarbulescu Date: Fri, 31 Jul 2026 21:42:13 +0300 Subject: [PATCH] fix(chat): keep streaming TTS visible to errors --- static/js/chat.js | 3 ++- tests/test_chat_stream_scope.py | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/static/js/chat.js b/static/js/chat.js index ea2d8c1bb..c00ed3a17 100644 --- a/static/js/chat.js +++ b/static/js/chat.js @@ -1367,6 +1367,7 @@ import { wireArrowUpRecall, getUserMessagesFromChatHistory } from './composerArr let _renderStream = () => {}; let _cancelThinkingTimer = () => {}; let _removeThinkingSpinner = () => {}; + let streamingTTS = false; let timeoutId = null; let responseTimeoutCleared = false; let clearResponseTimeout = () => {}; @@ -1897,7 +1898,7 @@ import { wireArrowUpRecall, getUserMessagesFromChatHistory } from './composerArr let isThinking = false; let thinkingStartTime = null; // Streaming TTS: synthesize sentence-by-sentence during streaming - const streamingTTS = !!(window.aiTTSManager && window.aiTTSManager.autoPlay && window.aiTTSManager.available); + streamingTTS = !!(window.aiTTSManager && window.aiTTSManager.autoPlay && window.aiTTSManager.available); if (streamingTTS) window.aiTTSManager.streamingStart(); // Multi-bubble agent tracking let roundHolder = holder; // Current AI text bubble (changes per round) diff --git a/tests/test_chat_stream_scope.py b/tests/test_chat_stream_scope.py index a726c776d..8322e37ee 100644 --- a/tests/test_chat_stream_scope.py +++ b/tests/test_chat_stream_scope.py @@ -12,8 +12,11 @@ def test_stream_render_helpers_are_visible_to_catch_block(): assert "let _renderStream = () => {};" in outer_scope assert "let _cancelThinkingTimer = () => {};" in outer_scope assert "let _removeThinkingSpinner = () => {};" in outer_scope + assert "let streamingTTS = false;" in outer_scope assert "_renderStream = () => {" in try_body assert "_cancelThinkingTimer = () => {" in try_body assert "_removeThinkingSpinner = () => {" in try_body + assert "streamingTTS = !!(" in try_body assert "function _renderStream()" not in try_body + assert "const streamingTTS" not in try_body