fix(email): open settings after OAuth callback (#5803)

static/js/settings.js

@@ -5790,14 +5790,14 @@ export function close() {
   window.history.replaceState(null, '', clean);
   const success = sp.has('email_oauth_success');
   const errMsg = sp.get('email_oauth_error') || '';
-  // Open settings → integrations after the app has initialised.
+  // Open settings → integrations once the document is ready. This module owns
-  function _tryOpen() {
+  // the open() API, so it does not need to wait for a window-level alias.
-    if (window.settingsModule && typeof window.settingsModule.open === 'function') {
+  function _showResult() {
-      window.settingsModule.open('integrations');
+    open('integrations');
     // Brief toast-style banner.
     const banner = document.createElement('div');
     banner.textContent = success
-        ? '✓ Google account connected — email is ready'
+      ? 'Google account connected — email is ready'
       : `Google OAuth failed: ${errMsg || 'unknown error'}`;
     Object.assign(banner.style, {
       position: 'fixed', bottom: '24px', left: '50%', transform: 'translateX(-50%)',
@@ -5808,11 +5808,12 @@ export function close() {
     });
     document.body.appendChild(banner);
     setTimeout(() => banner.remove(), 4000);
+  }
+  if (document.readyState === 'loading') {
+    document.addEventListener('DOMContentLoaded', _showResult, { once: true });
   } else {
-      setTimeout(_tryOpen, 100);
+    _showResult();
   }
-  }
-  _tryOpen();
 })();
 
 const settingsModule = { open, close, initIntegrations, initUnifiedIntegrations, syncAdminVisibility, refreshAiModelEndpoints };

tests/test_email_oauth_settings_redirect.py

@@ -0,0 +1,19 @@
+"""Regression coverage for the settings UI after Google OAuth redirects."""
+
+from pathlib import Path
+
+
+_REPO = Path(__file__).resolve().parents[1]
+
+
+def test_oauth_redirect_uses_the_module_local_settings_api():
+    source = (_REPO / "static" / "js" / "settings.js").read_text(encoding="utf-8")
+    handler = source[
+        source.index("(function _handleOauthRedirect"):
+        source.index("const settingsModule =")
+    ]
+
+    assert "open('integrations');" in handler
+    assert "window.settingsModule" not in handler
+    assert "window.__odysseusAppStarted" not in handler
+    assert "document.addEventListener('DOMContentLoaded', _showResult, { once: true })" in handler